Skip to content

Conversation

@sebastiand-cerebras
Copy link

@sebastiand-cerebras sebastiand-cerebras commented Nov 4, 2025

Description

Updated maxTokens, contextWindow and description.

Test Procedure

n/a

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Documentation Updates

Additional Notes

Thank you so much!


Important

Update zai-glm-4.6 model in cerebras.ts with increased maxTokens, contextWindow, and revised description.

  • Model Updates:
    • In cerebras.ts, updated zai-glm-4.6 model:
      • maxTokens increased from 16,384 to 40,960.
      • contextWindow increased from 128,000 to 131,072.
      • description updated to "Highly intelligent general purpose model with up to 1,000 tokens/s".

This description was created by Ellipsis for 6260be2. You can customize this summary. It will automatically update as commits are pushed.

Updated maxTokens, contextWindow and description.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Nov 4, 2025
@roomote
Copy link

roomote bot commented Nov 4, 2025

See this task on Roo Code Cloud

Review complete. The maxTokens reduction to 16384 addresses maintainer feedback appropriately. No new issues found.

Previous Reviews

Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 4, 2025
"zai-glm-4.6": {
maxTokens: 16_384,
contextWindow: 128000,
maxTokens: 40960,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sebastiand-cerebras, I'm up for whatever you all think is best but personally I think reserving that many tokens for output is a little much for a 131k context window.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matt,

Thank you so much for your message! We decided to go for this value across our external messaging but I see that it's rather a theoretical value. Would you want me to reduce it in the case of roocode? Wouldn't be an issue!

Btw, I am a big fan :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Yeah personally I've found 16k to be enough for coding, and then you reserve ~115k for task history before condensing etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the maxTokens. What do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 4, 2025
@mrubens mrubens merged commit ae9f3fe into RooCodeInc:main Nov 5, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 5, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants